W3C home > Mailing lists > Public > public-webrtc-logs@w3.org > February 2019

Re: [webrtc-pc] transceiver.stop() shouldn't block in-progress replaceTrack from succeeding (#2106)

From: Jan-Ivar Bruaroey via GitHub <sysbot+gh@w3.org>
Date: Tue, 19 Feb 2019 20:27:42 +0000
To: public-webrtc-logs@w3.org
Message-ID: <issue_comment.created-465296690-1550608061-sysbot+gh@w3.org>
> Agree that the promise should be rejected or resolved.

That's not actually a thing in JS.

> However, we don't seem to have been consistent with respect to this throughout the specification.
>
> For example, several of the "If connection's [[IsClosed]] slot is true, then abort these steps." instances would appear to result in a promise never being rejected or resolved. An example is `addIceCandidate`. Was this what we really intended?

I believe we're consistent: Outstanding Pomises are left pending on `pc.close()`. https://github.com/w3c/webrtc-pc/issues/150#issuecomment-152333247


-- 
GitHub Notification of comment by jan-ivar
Please view or discuss this issue at https://github.com/w3c/webrtc-pc/issues/2106#issuecomment-465296690 using your GitHub account
Received on Tuesday, 19 February 2019 20:27:44 UTC

This archive was generated by hypermail 2.3.1 : Tuesday, 4 June 2019 15:32:55 UTC