W3C home > Mailing lists > Public > public-webrtc-logs@w3.org > August 2018

Re: [webrtc-pc] Superfluous union in addIceCandidate.

From: Bernard Aboba via GitHub <sysbot+gh@w3.org>
Date: Mon, 06 Aug 2018 22:45:33 +0000
To: public-webrtc-logs@w3.org
Message-ID: <issue_comment.created-410876425-1533595532-sysbot+gh@w3.org>
@jan-ivar That is correct, but there may be some other archeological remains to be sorted out.
Do you recall why `RTCIceCandidate` was defined as an interface instead of a dictionary (as it is in ORTC)?

I seem to recall that the union arose from the desire to enable existing implementations to continue to work while moving toward `RTCIceCandidate` as the argument to ICE-related methods.  But if `RTCIceCandidate` had been a dictionary, would this have been needed??

I would note that extension specifications such as WebRTC-ICE utilize `RTCIceCandidate` as an argument to added methods (see: https://w3c.github.io/webrtc-ice/), so I'd like to figure out whether this change has implications for other specification as well.

-- 
GitHub Notification of comment by aboba
Please view or discuss this issue at https://github.com/w3c/webrtc-pc/issues/1954#issuecomment-410876425 using your GitHub account
Received on Monday, 6 August 2018 22:45:45 UTC

This archive was generated by hypermail 2.4.0 : Friday, 17 January 2020 19:22:04 UTC