Re: [webrtc-pc] Superfluous union in addIceCandidate.

@aboba See https://github.com/w3c/webrtc-pc/pull/407. In short, because of [RTCPeerConnectionIceEvent](http://w3c.github.io/webrtc-pc/#idl-def-rtcpeerconnectioniceevent). A [dictionary](https://heycam.github.io/webidl/#dfn-partial-dictionary) cannot be an attribute.

AFAICT the union was never necessary; an overlooked simplification. I don't find anything pointing to there ever having been a desire to move to interfaces as arguments, quite the opposite. Instead of:
```js
addIceCandidate(new RTCIceCandidate(msg.candidate));
```
...I recall we preferred the less cumbersome and more direct:
```js
addIceCandidate(msg.candidate);
```
I remember we did the same to `RTCSessionDescription` and its various uses in method.

-- 
GitHub Notification of comment by jan-ivar
Please view or discuss this issue at https://github.com/w3c/webrtc-pc/issues/1954#issuecomment-410909787 using your GitHub account

Received on Tuesday, 7 August 2018 02:10:29 UTC