W3C home > Mailing lists > Public > public-webrtc-logs@w3.org > October 2017

Re: [webrtc-pc] Need for Initial Bitrate by the Application/RtpSender?

From: Taylor Brandstetter via GitHub <sysbot+gh@w3.org>
Date: Sat, 21 Oct 2017 04:46:01 +0000
To: public-webrtc-logs@w3.org
Message-ID: <issue_comment.created-338363849-1508561159-sysbot+gh@w3.org>
> Wouldn't the congestion control reset when the ICE candidates change?

Right, which would be why, just like for the initial connection, the application may have some knowledge it can use to populate a better initial estimate.

Also: with your suggestion, what happens if I call `pc.setConfiguration(pc.getConfiguration())`? `getConfiguration()` returns the previously set value, so what happens when it gets passed back into `setConfiguration()`? Does it reset the bandwidth estimate? Or would would we have the rule "it's only reset if it's changed to a different value"? Then you have the corner case where you *want* to reset it to the same value as before, and need to add/remove 1 to make it different.

This is the exact conversation we had during code review, and why we decided it was cleaner to just make it a separate API from `setConfiguration`. The "get/set" model just didn't really make sense for it, and there wasn't a good reason to *not* add a new method.

-- 
GitHub Notification of comment by taylor-b
Please view or discuss this issue at https://github.com/w3c/webrtc-pc/issues/1635#issuecomment-338363849 using your GitHub account
Received on Saturday, 21 October 2017 04:46:28 UTC

This archive was generated by hypermail 2.3.1 : Wednesday, 9 October 2019 15:14:56 UTC