W3C home > Mailing lists > Public > public-webrtc-logs@w3.org > May 2017

[webrtc-pc] Pull Request: Add detailed steps for constructing RTCIceCandidate

From: Soares Chen via GitHub <sysbot+gh@w3.org>
Date: Fri, 19 May 2017 10:09:55 +0000
To: public-webrtc-logs@w3.org
Message-ID: <pull_request.opened-121467597-1495188593-sysbot+gh@w3.org>
soareschen has just submitted a new pull request for https://github.com/w3c/webrtc-pc:

== Add detailed steps for constructing RTCIceCandidate ==
This PR address the issues in #1165 and #1224. It is also needed to have complete test coverage for `RTCIceCandidate()` in w3c/web-platform-tests#5917.

I am not very sure of the details for editing the spec, so this is a first cut draft that attempt to explain the changes to be made.

The main change is to add detailed steps for the `RTCIceCandidate` constructor to parse the candidate string, referencing the relevant specs, and populating the attributes with the parse result. 

To maintain backward compatibility, any parsing error is ignored and the derivative attributes are simply set with the default `null` value. This might not be the best approach, but I am not sure if we can make it throw an error since current browser implementations do not have the derivative attributes and have not done any parsing on the candidate string.

See https://github.com/w3c/webrtc-pc/pull/1229
Received on Friday, 19 May 2017 10:10:01 UTC

This archive was generated by hypermail 2.4.0 : Saturday, 6 May 2023 21:19:41 UTC