W3C home > Mailing lists > Public > public-webrtc-logs@w3.org > May 2017

Re: [webrtc-pc] addIceCandidate end of candidates woes

From: Philipp Hancke via GitHub <sysbot+gh@w3.org>
Date: Tue, 16 May 2017 18:19:08 +0000
To: public-webrtc-logs@w3.org
Message-ID: <issue_comment.created-301870265-1494958746-sysbot+gh@w3.org>
If we do bad hacks then I don't see a reason not to allow null in addIceCandidate.

I have written code that assumes that for any candidate event where e.candidate is set the candidate can be parsed. This code will probably throw an exception (inside the event handler) when trying to parse an empty string.

You might also want to revert https://github.com/webrtc/samples/pull/866 if you think it is incorrect.

GitHub Notification of comment by fippo
Please view or discuss this issue at https://github.com/w3c/webrtc-pc/issues/1213#issuecomment-301870265 using your GitHub account
Received on Tuesday, 16 May 2017 18:19:19 UTC

This archive was generated by hypermail 2.4.0 : Saturday, 6 May 2023 21:19:41 UTC