W3C home > Mailing lists > Public > public-webrtc-logs@w3.org > May 2017

Re: [webrtc-pc] RTCIceCandidate constructor should not require sdpMid/sdpMLineIndex

From: Taylor Brandstetter via GitHub <sysbot+gh@w3.org>
Date: Fri, 12 May 2017 16:51:25 +0000
To: public-webrtc-logs@w3.org
Message-ID: <issue_comment.created-301128876-1494607884-sysbot+gh@w3.org>
> My main point in this bug is that no engine currently requires one of sdpMid/sdpMLineIndex to be present, and adding that requirement comes with a compat risk, as any code in the wild that doesn't include one of these will start throwing.

I don't think this matters much, since any code in the wild doing that would fail immediately afterwards inside `addIceCandidate`. But if we want to do all the parameter checking in `addIceCandidate`, I don't see a problem with that; there's less duplication that way.

GitHub Notification of comment by taylor-b
Please view or discuss this issue at https://github.com/w3c/webrtc-pc/issues/1166#issuecomment-301128876 using your GitHub account
Received on Friday, 12 May 2017 16:51:31 UTC

This archive was generated by hypermail 2.4.0 : Saturday, 6 May 2023 21:19:40 UTC