W3C home > Mailing lists > Public > public-webrtc-logs@w3.org > May 2017

Re: [webrtc-pc] Race condition between createOffer and setIdentityProvider

From: Taylor Brandstetter via GitHub <sysbot+gh@w3.org>
Date: Wed, 10 May 2017 16:47:52 +0000
To: public-webrtc-logs@w3.org
Message-ID: <issue_comment.created-300543519-1494434871-sysbot+gh@w3.org> 
You're right... But what if you call `createOffer` again after `setIdentityProvider(b)`? The second identity assertion request process could complete before the first `createOffer` call starts generating SDP.

This could be fixed pretty trivially by storing a reference to the identity provider in the synchronous part, and saying "generate an offer according to JSEP, using the identity assertion from *provider* if *provider* is defined".

-- 
GitHub Notification of comment by taylor-b
Please view or discuss this issue at https://github.com/w3c/webrtc-pc/issues/1184#issuecomment-300543519 using your GitHub account
Received on Wednesday, 10 May 2017 16:47:58 UTC

This archive was generated by hypermail 2.4.0 : Saturday, 6 May 2023 21:19:40 UTC