W3C home > Mailing lists > Public > public-webrtc-logs@w3.org > May 2017

Re: [webrtc-pc] Add paragraph about RtpContributingSources being updated simultaneously.

From: jan-ivar via GitHub <sysbot+gh@w3.org>
Date: Thu, 04 May 2017 22:19:10 +0000
To: public-webrtc-logs@w3.org
Message-ID: <issue_comment.created-299325083-1493936349-sysbot+gh@w3.org>
@taylor-b Ah, I had forgotten about the performance issue @jesup and I were supposed to look at here. In light of that, I'm fine either way.

Your implementation looks good to me. As for indistinguishable, you might consider queuing a task instead of a micro-task, otherwise I could observe a difference like this:
let a = receiver.getContributingSources();
await Promise.resolve();
let b = receiver.getContributingSources();
log(JSON.stringify(a) == JSON.stringify(b)); // false
Not a problem per se, just different. I'm actually not sure what the TAG view is on state changes in the microtask queue.

GitHub Notification of comment by jan-ivar
Please view or discuss this issue at https://github.com/w3c/webrtc-pc/pull/1149#issuecomment-299325083 using your GitHub account
Received on Thursday, 4 May 2017 22:19:16 UTC

This archive was generated by hypermail 2.4.0 : Saturday, 6 May 2023 21:19:40 UTC