W3C home > Mailing lists > Public > public-webrtc-logs@w3.org > March 2017

Re: [webrtc-pc] Candidate from onicecandidate event and addIceCandidate are incompatible

From: Taylor Brandstetter via GitHub <sysbot+gh@w3.org>
Date: Fri, 17 Mar 2017 21:36:47 +0000
To: public-webrtc-logs@w3.org
Message-ID: <issue_comment.created-287477497-1489786605-sysbot+gh@w3.org>
> Does it only return a single event with null to indicate end-of-candidates or does it return both

Both.

> It is: https://github.com/w3c/webrtc-pc/blob/387e0bdb4e7db21e754209f8f0a1bb5e2f3cb333/webrtc.html#L2286

Oh, that appears to just be one place we forgot to update. In the WebIDL it's not nullable.

> And if we really want to keep backwards compatibility to the specification, I think allowing null is correct. 

But, as far as I'm aware, no browser implemented accepting a null argument. So there shouldn't be a backwards compatibility concern.

-- 
GitHub Notification of comment by taylor-b
Please view or discuss this issue at https://github.com/w3c/webrtc-pc/issues/1077#issuecomment-287477497 using your GitHub account
Received on Friday, 17 March 2017 21:36:53 UTC

This archive was generated by hypermail 2.3.1 : Wednesday, 9 October 2019 15:14:52 UTC