W3C home > Mailing lists > Public > public-webrtc-logs@w3.org > March 2017

[webrtc-pc] Candidate from onicecandidate event and addIceCandidate are incompatible

From: Lennart Grahl via GitHub <sysbot+gh@w3.org>
Date: Wed, 15 Mar 2017 11:18:12 +0000
To: public-webrtc-logs@w3.org
Message-ID: <issues.opened-214358243-1489576690-sysbot+gh@w3.org>
lgrahl has just created a new issue for https://github.com/w3c/webrtc-pc:

== Candidate from onicecandidate event and addIceCandidate are incompatible ==
The `addIceCandidate` method states:

> This method can also be used to indicate the end of remote candidates when called with an empty string for candidate.

First of all, do you mean the **member** `candidate` can be empty string or the **argument** `candidate` can be empty string? I'm guessing you mean the member but please clarify this in the description.
Please also state what should happen in case the argument `candidate` is `null`. Is this still an end of candidate indication but for all mids (as it was before)? I guess it would have to be to ensure backwards compatibility.

To the main issue: `RTCPeerConnectionIceEvent` contains an attribute `candidate` which states:

> This attribute is set to null when an event is generated to indicate the end of candidate gathering.

I guess this has just not been updated to the changes to `addIceCandidate`. I would expect the `candidate` attribute to always contain an `RTCIceCandidate` which cannot be `null` (instead, `candidate.candidate` would be an empty string).

Please view or discuss this issue at https://github.com/w3c/webrtc-pc/issues/1077 using your GitHub account
Received on Wednesday, 15 March 2017 11:18:18 UTC

This archive was generated by hypermail 2.4.0 : Saturday, 6 May 2023 21:19:40 UTC