W3C home > Mailing lists > Public > public-webrtc-logs@w3.org > July 2017

Re: [webrtc-pc] setRemoteDescription should fail if target peer identity is set but no a=identity in SDP

From: Soares Chen via GitHub <sysbot+gh@w3.org>
Date: Thu, 27 Jul 2017 07:51:31 +0000
To: public-webrtc-logs@w3.org
Message-ID: <issue_comment.created-318286980-1501141889-sysbot+gh@w3.org>
>  In we check the identity every time. If a=identity isn't present, then we set the actual identity to null. If we have a target identity, then setRemoteDescription without a=identity causes a failure.

If so then the spec should add some steps to clarify. For example something like:

> (Introduce new variable, e.g. _newPeerIdentity_)
>
> If an a=identity attribute is present in the session description, let _newPeerIdentity_ be the result of validating the identity assertion. Else let _newPeerIdentity_ be null.
>
> If target peer identity is set and is different from _newPeerIdentity_, the user agent MUST reject the returned promise with a newly created InvalidModificationError and abort this operation. The RTCPeerConnection MUST be closed if the validated peer identity does not match the target peer identity. Else set target peer identity to _newPeerIdentity_.

This would have a few implications:

- If SRD is first called with a=identity then without it, the operation fails with `InvalidModificationError` and the connection closes.
- If SRD is first called with no a=identity then with it, the operation also fails with `InvalidModificationError` and the connection closes.

-- 
GitHub Notification of comment by soareschen
Please view or discuss this issue at https://github.com/w3c/webrtc-pc/issues/1512#issuecomment-318286980 using your GitHub account
Received on Thursday, 27 July 2017 07:51:36 UTC

This archive was generated by hypermail 2.4.0 : Friday, 17 January 2020 19:21:40 UTC