W3C home > Mailing lists > Public > public-webrtc-logs@w3.org > July 2017

Re: [webrtc-pc] setRemoteDescription should fail if target peer identity is set but no a=identity in SDP

From: Martin Thomson via GitHub <sysbot+gh@w3.org>
Date: Thu, 27 Jul 2017 07:22:41 +0000
To: public-webrtc-logs@w3.org
Message-ID: <issue_comment.created-318281030-1501140159-sysbot+gh@w3.org>
Seems reasonable.

You had me worried there for a minute.  In we check the identity every time.  If `a=identity` isn't present, then we set the actual identity to `null`.  If we have a target identity, then `setRemoteDescription` without `a=identity` causes a failure.

-- 
GitHub Notification of comment by martinthomson
Please view or discuss this issue at https://github.com/w3c/webrtc-pc/issues/1512#issuecomment-318281030 using your GitHub account
Received on Thursday, 27 July 2017 07:22:50 UTC

This archive was generated by hypermail 2.4.0 : Friday, 17 January 2020 19:21:40 UTC