- From: Cullen Jennings (fluffy) <fluffy@cisco.com>
- Date: Thu, 2 Nov 2017 12:17:26 +0000
- To: Harald Alvestrand <hta@google.com>
- CC: Stefan Håkansson <stefan.lk.hakansson@ericsson.com>, Dominique Hazaël-Massieux <dom@w3.org>, "vivien@w3.org" <vivien@w3.org>, Bernard Aboba <Bernard.Aboba@microsoft.com>, "webrtc-editors@alvestrand.no" <webrtc-editors@alvestrand.no>
Totally makes sense they are merged in the meeting. I was just surprised to get that all open PR needed review. However, after review them all, they mostly were all ready to merge. In general, how about I'm happy to review them once someone on the editor / chair team thinks they are ready to merge - I imagine that would often be the author of the PR. I know sometimes on the call it will turn out they were not and changes will be made and I will review. That is fine. I just don't want to be reviewing stuff that is definitely not ready. > On Nov 2, 2017, at 6:05 AM, Harald Alvestrand <hta@google.com> wrote: > > Our process on the editors' call has been to declare them ready and then hit the merge button instantly, which means we don't know if they're ready before the call. But most late changes are not technically significant. > > Usually the status is obvious; the only iffy one this time around is probably the bandwidth control one, which I don't think is ready (and, in my personal opinion, is not right either). That one doesn't have a review request on it; all the others have (as of now, I see one was added 2 hours ago). > > > On Thu, Nov 2, 2017 at 12:58 PM, Cullen Jennings (fluffy) <fluffy@cisco.com> wrote: > So just checking that theses are all ready to merge before I review so if they look OK from IPR I can hit merge? If there are only some that we think are ready to merge can we identify the ones that are ready for me to review by just doing a review request in github ? > > I will go and review all of theses this morning before the editor call but in general the process was to review once they were ready to merge. > > > > > On Nov 2, 2017, at 3:44 AM, Stefan Håkansson LK <stefan.lk.hakansson@ericsson.com> wrote: > > > > Hi Cullen, > > > > we've moved to the new publication process (where a new Ed's draft is > > automatically published when a PR is merged). > > > > Can you review the PRs at https://github.com/w3c/webrtc-pc/pulls from an > > IPR perspective? > > > > Br, > > Stefan > >
Received on Thursday, 2 November 2017 12:28:03 UTC