[Bug 19302] Comments extension causes an infinite loop

https://www.w3.org/Bugs/Public/show_bug.cgi?id=19302

Markus Glaser <glaser@hallowelt.biz> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |ASSIGNED
                 CC|                            |glaser@hallowelt.biz
         AssignedTo|schepers@w3.org             |glaser@hallowelt.biz

--- Comment #2 from Markus Glaser <glaser@hallowelt.biz> 2012-10-06 00:26:48 UTC ---
I found a hook look in OutputPageBeforeHTML: Comments extension binds to
OutputPageBeforeHTML. This in turn calls SemanticForms, which adds text to the
wgOut object, which in turn calls OutputPageBeforeHTML.

In order to fix it, I put a flag in the main rendering function in Comments
that indicates that rendering is already in progress and prevents another
execution of the hooked function.

For testing, I created a new account and did not confirm any email. Then I went
to the problematic article and added a comment. This worked for me.

As of now, the fix is only applied to the test system. I'd be happy if someone
else tests and confirms the bug is resolved.

-- 
Configure bugmail: https://www.w3.org/Bugs/Public/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.

Received on Saturday, 6 October 2012 00:26:50 UTC