Re: [w3c/payment-request] Derive direction from document element too (#956)

@aphillips requested changes on this pull request.

Generally looks good. Small tweaks proposed.

> @@ -1139,20 +1139,23 @@ <h2>
               Present a user interface that will allow the user to interact
               with the |handlers|. The user agent SHOULD prioritize the user's
               preference when presenting payment methods. The user interface
-              SHOULD be presented using the language and locale-based
-              formatting that matches the |document|'s [=document
-              element|document element's=] [=Node/language=], if any, or an
-              appropriate fallback locale if that is not available.
+              SHOULD be presented using the language, base direction, and
+              locale-based formatting that matches the |document|'s [=document
+              element|document element's=] [=Node/language=] and
+              {{Document/dir}} attribute, if any, or an appropriate fallback

The direction should also be at the Node level, no?

> @@ -1139,20 +1139,23 @@ <h2>
               Present a user interface that will allow the user to interact
               with the |handlers|. The user agent SHOULD prioritize the user's
               preference when presenting payment methods. The user interface
-              SHOULD be presented using the language and locale-based
-              formatting that matches the |document|'s [=document
-              element|document element's=] [=Node/language=], if any, or an
-              appropriate fallback locale if that is not available.
+              SHOULD be presented using the language, base direction, and
+              locale-based formatting that matches the |document|'s [=document
+              element|document element's=] [=Node/language=] and
+              {{Document/dir}} attribute, if any, or an appropriate fallback
+              locale if that is not available.

Omit `locale` since this is both locale and direction now?

> +                working group is considering support for fine-grained
+                localization of the user interface and of individual

I'd probably change "fine-grained" to "control of" (too strong?) or perhaps "requesting  specific"

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/w3c/payment-request/pull/956#pullrequestreview-656809488