- From: Stephen McGruer <notifications@github.com>
- Date: Thu, 12 Aug 2021 07:33:07 -0700
- To: w3c/payment-request <payment-request@noreply.github.com>
- Cc: Subscribed <subscribed@noreply.github.com>
Received on Thursday, 12 August 2021 14:33:19 UTC
@stephenmcgruer approved this pull request. I tried to find some prior art here on whether to throw a NotAllowed or SecurityError, and came up short 😂 . What I did find: 1. webusb and webbluetooth throw a SecurityError 1. One other spec I found threw NotAllowedError, but most other specs just quietly return or ignore calls/etc when there is no activation. 1. We [used to](https://github.com/w3c/payment-request/pull/885/files) throw SecurityError, then [switched](https://github.com/w3c/payment-request/pull/916/files) to NotAllowedError without documented reason that I could find. So... SecurityError LGTM? Maybe something the web should standardize on ;) -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/w3c/payment-request/pull/961#pullrequestreview-728699279
Received on Thursday, 12 August 2021 14:33:19 UTC