Re: [w3c/payment-request] Define handling of multiple applicable modifiers (#824)

domenic approved this pull request.

LGTM with nits

> +    },
+  },
+  // Applies only to visa cards...
+  {
+    additionalDisplayItems: [visaFee],
+    supportedMethods: "basic-card",
+    total: {
+      label: "Total due",
+      amount: { currency: "USD", value: "51.00" },
+    },
+    data: {
+      supportedNetworks: ["visa"] // Visa network only
+    },
+  },
+];
+Object.assign(details, { modifiers });

Not sure where `details` is declared, but just `details.modifiers = modifiers` is simpler.

> +    additionalDisplayItems: [visaFee],
+    supportedMethods: "basic-card",
+    total: {
+      label: "Total due",
+      amount: { currency: "USD", value: "51.00" },
+    },
+    data: {
+      supportedNetworks: ["visa"] // Visa network only
+    },
+  },
+];
+Object.assign(details, { modifiers });
+              </pre>
+              <p>
+                If the modifiers array in the example above was to be reversed
+                (i.e., <code class="js">supportedNetworks: []</code>) was to

```suggestion
                (i.e., <code class="js">supportedNetworks: []</code> was to
```

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/w3c/payment-request/pull/824#pullrequestreview-198290900