- From: Domenic Denicola <notifications@github.com>
- Date: Mon, 09 Dec 2019 07:00:38 -0800
- To: w3c/payment-request <payment-request@noreply.github.com>
- Cc: Subscribed <subscribed@noreply.github.com>
- Message-ID: <w3c/payment-request/pull/885/review/328981663@github.com>
domenic commented on this pull request. > @@ -956,11 +956,13 @@ <h2> follows: </p> <ol class="algorithm"> + <li>Let |window:Window| be the [=relevant global object=] of the + [=environment settings object/responsible document=]. I don't think there are really any shortcuts here. The "get in and out as quickly as possible" attitude is not tenable, and I'm not OK with making edits to HTML to encourage it. As a spec editor, dealing with global objects is one of the most fundamental things one needs to understand. One needs to read and grok that section fully. In particular, the latest patch is missing a statement of which object's relevant global you are looking at. This is emphasized three times in the section I pointed you at: > When writing algorithms, **the most prominent platform object whose relevant Realm might be important is the this value of the currently-running function object.** In some cases, there can be other important relevant Realms, such as those of any arguments. and > Note how the entry, incumbent, and current concepts are usable without qualification, whereas the relevant concept must be applied to a particular platform object. and > In general, web platform specifications should use the relevant concept, applied to the object being operated on (**usually the this value of the current method**). I'm not really sure how to deal with situations where we have three separate sentences attempting to make something clear, but spec editors are attempting to skim and thus missing them... Suggestions appreciated. I think in the end it may be offputting that you're coming to this understanding via something that used to be simple-but-wrong (user activation), and being forced to grasp the concept of different global objects in order to fix user activation. But fundamentally different global object usage pervades all specs, including this one; we've spent several issue threads previously working on this (e.g. https://github.com/w3c/payment-request/pull/811). -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/w3c/payment-request/pull/885#discussion_r355497732
Received on Monday, 9 December 2019 15:00:40 UTC