- From: Domenic Denicola <notifications@github.com>
- Date: Fri, 06 Dec 2019 11:50:50 -0800
- To: w3c/payment-request <payment-request@noreply.github.com>
- Cc: Subscribed <subscribed@noreply.github.com>
Received on Friday, 6 December 2019 19:50:52 UTC
domenic commented on this pull request. Mostly seems good. Should this consume user activation, or just observe it? That's probably a question for implementers and/or the working group? > @@ -956,11 +956,13 @@ <h2> follows: </p> <ol class="algorithm"> + <li>Let |window:Window| be the [=relevant global object=] of the + [=environment settings object/responsible document=]. Which environment settings object's responsible document is this? You should use the relevant global object of [this](https://heycam.github.io/webidl/#this) instead. See the general advice in https://html.spec.whatwg.org/multipage/webappapis.html#realms-settings-objects-global-objects -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/w3c/payment-request/pull/885#pullrequestreview-328421460
Received on Friday, 6 December 2019 19:50:52 UTC