Re: [w3c/payment-handler] Notify merchant that payment method (possibly including the billing address) changed in payment handler. (#318)

romandev commented on this pull request.

Overall looks good to me. I left minor comments for API shape.

> @@ -1169,10 +1226,12 @@ <h2>
           readonly attribute USVString paymentRequestOrigin;
           readonly attribute DOMString paymentRequestId;
           readonly attribute FrozenArray&lt;PaymentMethodData&gt; methodData;
-          readonly attribute object total;
+          readonly attribute PaymentCurrencyAmount total;

nit: This should be `object` type.
According to the WebIDL spec[1], Dictionaries must not be used as the type of an attribute or constant.
[1] https://heycam.github.io/webidl/#idl-dictionary

>            Promise&lt;WindowClient?&gt; openWindow(USVString url);
+          Promise&lt;PaymentMethodChangeResponse?&gt; changePaymentMethod(DOMString methodName, object? methodDetails);

nit: I think that making the second parameter as `optional` would be better.
```webidl
Promise<PaymentMethodChangeResponse?> changePaymentMethod(DOMString methodName, optional object? methodDetails = null);
```

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/w3c/payment-handler/pull/318#pullrequestreview-154920689