- From: Domenic Denicola <notifications@github.com>
- Date: Wed, 12 Sep 2018 07:08:37 -0700
- To: w3c/payment-request <payment-request@noreply.github.com>
- Cc: Subscribed <subscribed@noreply.github.com>
Received on Wednesday, 12 September 2018 14:08:59 UTC
domenic approved this pull request. > @@ -3858,6 +3865,17 @@ <h3> <li>Initialize <var>event</var>.<a>validationURL</a> attribute to <var>validationURL</var>. </li> + <li>If <var>eventInitDict</var>["<a>methodName</a>"] is not the + empty string, run the steps to <a data-cite= + "payment-method-id#dfn-validate-a-payment-method-identifier">validate + a payment method identifier</a> with + <var>eventInitDict</var>["<a>methodName</a>"]. If it returns false, I'm always unsure how much validation we should be doing in event constructors, i.e. should they be dumb property bags that hold whatever you pass in, or should they enforce domain logic constraints. But this is good for now, and consistent. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/w3c/payment-request/pull/776#pullrequestreview-154666647
Received on Wednesday, 12 September 2018 14:08:59 UTC