Re: [w3c/payment-request] Add paymentMethodErrors, payerErrors, to PaymentDetailsUpdate (#768)

romandev approved this pull request.

Sorry for delayed reply.
This seems reasonable to me for consistency.

One question is whether the some error values can be updated via ```updateWith()``` on an unrelated event.
For example, ```requestShipping``` and ```requestPayerName``` are all true and merchant calls ```updateWith()``` on payer detail change event as follows.
```
  response.addEventListener('payerdetailchange', e => {
    e.updateWith({
      shippingAddressErrors: { city: 'CITY ERROR' }
    });
  });
```

In this case, should we allow ```shippingAddressErrors``` to be updated on payer detail change event?
FYI, in Chromium implementation, if the ```shippingAddressErrors``` is present, shipping address editor will perform after ```updateWith()``` calls.

Thank you.



-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/w3c/payment-request/pull/768#pullrequestreview-151646708