Re: [w3c/payment-request] Retry request abort the update (#723)

domenic approved this pull request.

LGTM with wording tweaks to the note

>              Consequently, the <a>PaymentRequest</a> moves to a "<a>closed</a>"
             state. The error is signaled to the developer through the rejection
             of the <a>[[\acceptPromise]]</a>, i.e., the promise returned by
             <a data-lt="PaymentRequest.show">show()</a>.
           </p>
+          <p data-link-for="PaymentResponse">
+            Similarly, aborting the update occurs during a <a>retry()</a> will

This sentence doesn't read right... "aborting the update occurs during a retry() will cause"?

>              Consequently, the <a>PaymentRequest</a> moves to a "<a>closed</a>"
             state. The error is signaled to the developer through the rejection
             of the <a>[[\acceptPromise]]</a>, i.e., the promise returned by
             <a data-lt="PaymentRequest.show">show()</a>.
           </p>
+          <p data-link-for="PaymentResponse">
+            Similarly, aborting the update occurs during a <a>retry()</a> will
+            cause the <a>[[\retryPromise]]</a> to reject, and the corresponding
+            <a>PaymentRequest</a>'s <a>[[\complete]]</a> internal slot will be
+            set to true (i.e., meaning it can no longer be used).

"i.e." and "meaning" seem redundant; pick one or the other.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/w3c/payment-request/pull/723#pullrequestreview-132143565

Received on Tuesday, 26 June 2018 18:12:41 UTC