- From: Marcos Cáceres <notifications@github.com>
- Date: Thu, 12 Jul 2018 14:28:47 -0700
- To: w3c/payment-request <payment-request@noreply.github.com>
- Cc: Subscribed <subscribed@noreply.github.com>
Received on Thursday, 12 July 2018 21:29:16 UTC
Following on from #684, there are a bunch of huge issues in the spec relating to modifiers: * [[serializedMethodData]] is not actually used anywhere - it's undefined how that data actually gets applied/displayed. * [[serializedMethodData]] gathers all the data from EVERY modifier (without matching on PMI!), then passes ALL data to the chosen payment handler - in the spec, there is no way to distinguish between data for ApplePay and data for Basic-Card. * The modifiers in `serializedMethodData` are never converted, only serialized, meaning that if they are converted by the payment handler, they can throw: This is undefined behavior. * The actual serialization also seems pointless. If that's for IPC, then that should be an implementation detail. It doesn't seem to serve any purpose in the spec (because [[serializedMethodData]] is never actually used for anything). I'm again strongly inclined towards dropping modifiers in favor of something else. They are super broken, underspecified, and unnecessarily complicated. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/w3c/payment-request/issues/753
Received on Thursday, 12 July 2018 21:29:16 UTC