Re: [w3c/payment-request] Construct and set attrs on PaymentAddress (#607)

domenic approved this pull request.

LGTM with editorial suggestions. Great stuff.

>          </p>
       </section>
+      <section>
+        <h2>
+          Internal slots
+        </h2>
+        <table>
+          <tr>
+            <th>
+              Internal slot
+            </th>
+            <th>
+              Description

I like putting "Description (non-normative)" to be extra clear.

> @@ -1901,100 +1901,216 @@
           <dfn>country</dfn> attribute
         </h2>
         <p>

Above this we have "When called, run" for toJSON. To stay consistent in the tenses used, we should change that to "When called, runs".

> +              </li>
+              <li>If <var>request</var>.<a>[[\options]]</a>.<a data-lt=
+              "PaymentOptions.requestPayerPhone">requestPayerPhone</a> is
+              false, set the <a>[[\phone]]</a> internal slot of
+              <var>address</var> to the empty string. Otherwise, set the
+              <a>[[\phone]]</a> internal slot of <var>address</var> to a user
+              provided phone number, optionally formatted to adhere to
+              [[!E.164]], or to the empty string if none was provided.
+              </li>
+              <li>Set the <a>[[\languageCode]]</a> internal slot of
+              <var>address</var> to a <a data-cite=
+              "!BCP47#section-4.5">canonicalized language tag</a>, or to the
+              empty sting if none was provided.
+                <div class="issue" data-number="608"></div>
+              </li>
+              <li>Set the <a>[[\city]]</a> internal slot of <var>address</var>

We've used _address_.[[city]] before; I think it's best to be consistent.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/w3c/payment-request/pull/607#pullrequestreview-61322879