Re: [w3c/browser-payment-api] BREAKING CHANGE: change `supportedMethods` to DOMString (#551)

mnoorenberghe commented on this pull request.



>            PaymentItem total;
           sequence<PaymentItem> additionalDisplayItems;
           object data;
         };
       </pre>
       <p>
         The <a>PaymentDetailsModifier</a> dictionary provides details that
-        modify the <a>PaymentDetailsBase</a> based on <a>payment method
-        identifier</a>. It contains the following fields:
+        modify the <a>PaymentDetailsBase</a> based on a <a>payment method
+        identifier</a>. It contains the following members:
       </p>
       <dl>
         <dt>
           <dfn>supportedMethods</dfn>

> Should this be renamed to supportedMethod, now that it only takes a single payment method identifier?

This already threw me off when just looking at the spec. The plural name with a string type is confusing… I was wondering how we're serializing a list into a string (which would be unusual given we could use an array)… Was an implementer not willing to change it?

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/w3c/browser-payment-api/pull/551#discussion_r124460138