Re: [w3c/payment-handler] Define requestPermission() behavior. (#180)

adrianhopebailie requested changes on this pull request.



> +                <li>Let <var>permission</var> be the result of running
+                <a data-cite="!permissions#dfn-retrieve-the-permission-state">
+                  retrieve the permission state algorithm</a> of the permission
+                  associated with <a>payment handler</a>'s <a>origin</a>.
+                </li>
+                <li>If <var>permission</var> is "prompt", ask the user whether
+                allowing adding new payment instruments for the <a data-cite=
+                "!HTML#current-settings-object">current settings object</a>'s
+                origin is acceptable. If it is, set <var>permission</var> to
+                "granted", and "denied" otherwise.
+                </li>
+                <li>Resolve <var>p</var> with <var>permission</var>.
+                </li>
+              </ol>
+            </li>
+            <li>Return <var>p</var>

Shouldn't we return the promise before we resolve it?

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/w3c/payment-handler/pull/180#pullrequestreview-45639046