Re: [w3c/browser-payment-api] BREAKING CHANGE: change `supportedMethods` to DOMString (#551)

zcorpan commented on this pull request.



>            PaymentItem total;
           sequence<PaymentItem> additionalDisplayItems;
           object data;
         };
       </pre>
       <p>
         The <a>PaymentDetailsModifier</a> dictionary provides details that
-        modify the <a>PaymentDetailsBase</a> based on <a>payment method
-        identifier</a>. It contains the following fields:
+        modify the <a>PaymentDetailsBase</a> based on a <a>payment method
+        identifier</a>. It contains the following members:
       </p>
       <dl>
         <dt>
           <dfn>supportedMethods</dfn>

OK. So `["basic-card"]` would still work as it's casted to a DOMString "basic-card". An array with more than one value would concatenate with a comma, and likely (but not impossibly, as URLs can have commas) end up with an unsupported payment identifier. Is this intentional? Changing the name would be more of a clean slate, but I suppose risks ending up having to support both.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/w3c/browser-payment-api/pull/551#discussion_r122884629