- From: Domenic Denicola <notifications@github.com>
- Date: Mon, 12 Jun 2017 11:17:12 -0700
- To: w3c/browser-payment-api <browser-payment-api@noreply.github.com>
- Cc: Subscribed <subscribed@noreply.github.com>
Received on Monday, 12 June 2017 18:17:46 UTC
domenic approved this pull request. Hmm, do you really think NotAllowedError is the right choice? It implies the user denied permission, whereas I don't think permission was ever asked about whether you can update the payment details. I might go with InvalidStateError. But, LGTM, I am OK either way. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/w3c/browser-payment-api/pull/547#pullrequestreview-43520200
Received on Monday, 12 June 2017 18:17:46 UTC