- From: Jinho Bang <notifications@github.com>
- Date: Fri, 09 Jun 2017 11:51:20 -0700
- To: w3c/payment-handler <payment-handler@noreply.github.com>
- Cc: Subscribed <subscribed@noreply.github.com>
- Message-ID: <w3c/payment-handler/pull/174/review/43234294@github.com>
romandev commented on this pull request. > @@ -695,6 +695,21 @@ When called, this method executes the following steps: </p> <ol> + <li>If the <a data-lt="PaymentInstrument.icons">icons</a> member of + <var>details</var> is present, then for each <var>icon</var> in + <var>details</var>.<a data-lt="PaymentInstrument.icons">icons</a>: + <ol> + <li>If <var>icon</var>.<a data-lt="ImageObject.type">type</a> + is not a <a data-cite="#valid-mime-type">valid MIME type</a> or + the value of type is not a supported media format, then return + a <a>Promise</a> rejected with a <a>TypeError</a>. + </li> + <li>If <var>icon</var>.<a data-lt="ImageObject.sizes">sizes</a> + is not a <a data-lt="ImageObject.sizes">valid value</a>, then + return a <a>Promise</a> rejected with a <a>TypeError</a>. + </li> + </ol> + </li> IMHO, we can use relative URLs. I added parsing step for it as follows: > parsing image.src with the context object's relevant settings object's API base URL. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/w3c/payment-handler/pull/174#discussion_r121198238
Received on Friday, 9 June 2017 18:51:59 UTC