- From: Michael[tm] Smith <notifications@github.com>
- Date: Fri, 11 Aug 2017 20:07:50 -0700
- To: w3c/payment-method-basic-card <payment-method-basic-card@noreply.github.com>
- Cc: Subscribed <subscribed@noreply.github.com>
- Message-ID: <w3c/payment-method-basic-card/pull/39/review/55934498@github.com>
sideshowbarker commented on this pull request. > </li> <li> <p> - Let <var>card</var> be the result of the end user selecting or - inputing a <a>card</a> of <a>type</a> - <var>data</var>.<a>supportedTypes</a>, or any type if - <var>data</var>.<a>supportedTypes</a> is empty, and from one of the - <a>networks</a> in <var>cardNetworks</var>, or from any network if - <var>cardNetworks</var> is empty. User agents SHOULD validate card - details to make sure they adhere to the <a>type</a> and - <a>network</a> requirements (e.g., checking that "visa" card starts - with the number "4", etc.). + Let <var>card</var> be the result of the end user inputting a + <a>card</a> of <a>type</a> <var>data</var>.<a>supportedTypes</a>, + or any type if <var>data</var>.<a>supportedTypes</a> is empty. + Check that <var>card</var> is from one of the <a>networks</a> in + <var>cardNetworks</var>. Validate <var>card</var>'s <a>details</a> <var>cardNetworks</var>. Validate <var>card</var>'s <a>details</a> Unless I’m misunderstanding the `Validate … to make sure they adhere to any <a>type</a> and/or <a>network</a> requirements` isn’t not clearly normatively defined and if so is not implementable and should be dropped. Or else this should be replaced with language that is implementable (e.g., using a reference to a normative definition of the *validate* intended here). -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/w3c/payment-method-basic-card/pull/39#pullrequestreview-55934498
Received on Saturday, 12 August 2017 03:08:59 UTC