- From: Sergey Malkin <sergeym@microsoft.com>
- Date: Wed, 21 Sep 2016 18:33:03 +0000
- To: Khaled Hosny <khaledhosny@eglug.org>, Ned Holbrook <ned@apple.com>
- CC: "public-webfonts-wg@w3.org" <public-webfonts-wg@w3.org>
FYI: Edge already picked up this new version in latest public release, so it works fine on this test page.
Thanks,
Sergey
-----Original Message-----
From: Khaled Hosny [mailto:khaledhosny@eglug.org]
Sent: Wednesday, September 21, 2016 11:26 AM
To: Ned Holbrook <ned@apple.com>
Cc: public-webfonts-wg@w3.org
Subject: Re: WOFF2 failure
On Wed, Sep 21, 2016 at 11:11:12AM -0700, Ned Holbrook wrote:
> This is regarding <http://test.chrislewis.codes/woff2/>, found on <http://typedrawers.com/discussion/1775/browser-ots-rejections-for-woff2-but-not-woff>; the WOFF2 for the second line of the test page is not being used.
>
> I stepped through I discovered the failure is due to this code in woff2_dec.cc:
>
> if (PREDICT_FALSE(static_cast<uint64_t>(table.dst_offset + table.dst_length)
> > out->Size())) {
> return FONT_COMPRESSION_FAILURE();
> }
>
> At the point of failure:
> (lldb) p out->Size()
> (size_t) $7 = 405520
> (lldb) p table.dst_offset + table.dst_length
> (unsigned int) $8 = 417149
>
> Now, Khaled commented on the TypeDrawers page to suggest this check is
> overly strict. Does this mean the reference implementation needs to be
> fixed?
See:
https://github.com/google/woff2/pull/48
Regards,
Khaled
Received on Wednesday, 21 September 2016 18:33:58 UTC