W3C home > Mailing lists > Public > public-webauthn@w3.org > August 2019

[webauthn] Merged Pull Request: Fix #1268 Type transport strings as DOMStrings.

From: Akshay Kumar via GitHub <sysbot+gh@w3.org>
Date: Wed, 28 Aug 2019 19:10:17 +0000
To: public-webauthn@w3.org
Message-ID: <pull_request.closed-307060142-1567019416-sysbot+gh@w3.org>
akshayku has just merged agl's pull request 1275 for https://github.com/w3c/webauthn:

== Fix #1268 Type transport strings as DOMStrings. ==
Currently transports are represented as an enum. However, WebIDL has
strict enums. (I.e. an RP which sent an unrecognised transport would
make the whole structure unparsable.) This means that every time we add
a transport, we break all existing browsers.

In order to address this, this change retypes transports as plain
DOMStrings. The AuthenticatorTransport enum still exists, but now only
as documentation and registry — not as a factor in type-checking.

fixes #1268


<!--
    This comment and the below content is programatically generated.
    You may add a comma-separated list of anchors you'd like a
    direct link to below (e.g. #idl-serializers, #idl-sequence):

    Don't remove this comment or modify anything below this line.
    If you don't want a preview generated for this pull request,
    just replace the whole of this comment's content by "no preview"
    and remove what's below.
-->
***
<a href="https://pr-preview.s3.amazonaws.com/agl/webauthn/pull/1275.html" title="Last updated on Aug 21, 2019, 12:28 AM UTC (49e1f6f)">Preview</a> | <a href="https://pr-preview.s3.amazonaws.com/w3c/webauthn/1275/fc01edc...agl:49e1f6f.html" title="Last updated on Aug 21, 2019, 12:28 AM UTC (49e1f6f)">Diff</a>

See https://github.com/w3c/webauthn/pull/1275
Received on Wednesday, 28 August 2019 19:10:18 UTC

This archive was generated by hypermail 2.4.0 : Friday, 17 January 2020 18:59:06 UTC