Re: [webauthn] Misleading key order in attestation object diagram (#1274)

• From: =JeffH via GitHub <sysbot+gh@w3.org>
• Date: Thu, 15 Aug 2019 22:43:41 +0000
• To: public-webauthn@w3.org
• Message-ID: <issue_comment.created-521822979-1565909020-sysbot+gh@w3.org>

Thanks @emlun and to @agl whoi submitted the bug on Brave.  

It seems to me that we also need to modify the CDDL in [Section 6.4.4. Generating an Attestation Object](https://www.w3.org/TR/webauthn/#generating-an-attestation-object):

Old:
```cddl
    attObj = {
                authData: bytes,
                $$attStmtType
             }

    attStmtTemplate = (
                          fmt: text,
                          attStmt: { * tstr => any } ; Map is filled in by each concrete attStmtType
                      )
```
New:
```cddl
    attObj = {
                $$attStmtType           // this yields ordering of: "fmt", "attStmt", "authData"
                authData: bytes,
             }

    attStmtTemplate = (
                          fmt: text,
                          attStmt: { * tstr => any } ; Map is filled in by each concrete attStmtType
                      )
```


-- 
GitHub Notification of comment by equalsJeffH
Please view or discuss this issue at https://github.com/w3c/webauthn/issues/1274#issuecomment-521822979 using your GitHub account

Received on Thursday, 15 August 2019 22:43:43 UTC