W3C home > Mailing lists > Public > public-webauthn@w3.org > October 2017

Re: [webauthn] fixup algs contd 3

From: =JeffH via GitHub <sysbot+gh@w3.org>
Date: Thu, 19 Oct 2017 19:56:22 +0000
To: public-webauthn@w3.org
Message-ID: <issue_comment.created-338019206-1508442980-sysbot+gh@w3.org>
per 18-Oct webauthn call, I've addressed @jyasskin's latest comments.  This is ready to merge AFAIK.  Since I did make some modest changes in response to the latter comments, perhaps someone(s) oughta review prior to merge? 

Making similar changes to the #getAssertion section is yet to do in a separate soon-to-follow PR. 

Regarding [Rolf's oldish review](https://github.com/w3c/webauthn/pull/498#pullrequestreview-46490753) that is requesting changes, It seems to me that [there is nothing to do in response to it, unless I am misunderstanding things](https://github.com/w3c/webauthn/pull/498#issuecomment-332398969). [I ping'd him on-list](https://lists.w3.org/Archives/Public/public-webauthn/2017Sep/0458.html) a few weeks ago about this, but have not heard back.  So are we ok to "dismiss" is review in order to merge this?

thanks!



-- 
GitHub Notification of comment by equalsJeffH
Please view or discuss this issue at https://github.com/w3c/webauthn/pull/498#issuecomment-338019206 using your GitHub account
Received on Thursday, 19 October 2017 19:56:24 UTC

This archive was generated by hypermail 2.4.0 : Tuesday, 5 July 2022 07:26:29 UTC