W3C home > Mailing lists > Public > public-webauthn@w3.org > May 2017

Re: [webauthn] Adds requireUserVerification option in AuthenticatorSelectionCriteria

From: =JeffH via GitHub <sysbot+gh@w3.org>
Date: Wed, 10 May 2017 18:49:49 +0000
To: public-webauthn@w3.org
Message-ID: <issue_comment.created-300578241-1494442187-sysbot+gh@w3.org>
hey folks -- it looks to me like `requireUserVerification` and associated text was inadvertently removed by a cockpit error when resolving merge conflicts, in this commit:

https://github.com/w3c/webauthn/commit/5e860cd2c4c028d49601847022a84c465cae7815#diff-ec9cfa5f3f35ec1f84feb2e59686c34d

If you view the diff rendered by the above, then search for `requireUserVerif` and/or `<<<<<<< HEAD` you will find what seems to be a chunk of spec that ought not to have been removed when correcting merge conflicts.  

I note that the removed text was apparently added with the merge of PR #348 on Mon 24-Apr-2017. We discussed PR #348 on the [2017/04/19-webauthn call](https://www.w3.org/2017/04/19-webauthn-minutes.html)  and I do not see mentioned explicitly in those minutes that we agreed to merge #348 as-is (there are unresolved raised issues with it noted in the PR), but it was merged in any case. 

Thus I am thinking that it is OK to attempt to re-insert `requireUserVerification` and associated text in this new PR rather than try to go back and fix the merge-conflict-resolution-error, because we may or may not "need" this `requireUserVerification` now that we have a more refined notion of "authenticator selection" to work with.  

I'll try to catch up on @jyasskin's comments tomorrow and see about contributing to the discussion (it's getting to be past dinner time for me tonight here in CET)...

-- 
GitHub Notification of comment by equalsJeffH
Please view or discuss this issue at https://github.com/w3c/webauthn/pull/460#issuecomment-300578241 using your GitHub account
Received on Wednesday, 10 May 2017 18:49:55 UTC

This archive was generated by hypermail 2.4.0 : Tuesday, 5 July 2022 07:26:26 UTC