W3C home > Mailing lists > Public > public-webauthn@w3.org > March 2017

Re: [webauthn] Refine makeCredential description

From: =JeffH via GitHub <sysbot+gh@w3.org>
Date: Fri, 03 Mar 2017 17:09:00 +0000
To: public-webauthn@w3.org
Message-ID: <issue_comment.created-284011866-1488560938-sysbot+gh@w3.org>
thx @vijaybh, this looks LGTM overall. 

A few nits:

1. Line 1115: (`[=TUP=]`) is not rendering correctly, guess we should 
drop the   "[=...=]"  ?

2. Line 1098:
The encoding of authenticator data is a byte array of 37 bytes or 
more, as follows.

suggest:
The encoding of the [=authenticator data=] structure is as a byte 
array of 37 bytes or more, as follows:

3. there's various instances of "authenticator data" and "client data"
 that I'd give the "[=...=]" treatment, e.g. around line 1053,  and 
then for just "authenticator data" in lines 1086-1100, and then on 
down thru the spec.  Similarly for "client data" on down thru the 
spec.   [realizing that there's some instances of either where such a 
change is not appropriate]

do we want to address them now or in a future PR ?





-- 
GitHub Notification of comment by equalsJeffH
Please view or discuss this issue at 
https://github.com/w3c/webauthn/pull/369#issuecomment-284011866 using 
your GitHub account
Received on Friday, 3 March 2017 17:09:07 UTC

This archive was generated by hypermail 2.4.0 : Tuesday, 5 July 2022 07:26:24 UTC