W3C home > Mailing lists > Public > public-webappsec@w3.org > June 2014

Re: [webappsec] Help build the CSP test suite at Test the Web Forward Portland, August 3

From: Odin Hørthe Omdal <odinho@opera.com>
Date: Wed, 04 Jun 2014 23:39:10 +0200
Message-Id: <1401917950.17803.125269937.35C395CE@webmail.messagingengine.com>
To: public-webappsec@w3.org
Cc: Rebecca Hauck <rhauck@adobe.com>, jgraham@hoppipolla.co.uk
On Wed, Jun 4, 2014, at 22:53, Hill, Brad wrote:
> Can you point me at how users can see/test changes in real-time?  That
> was the other issue I had with using the "canonical" repo - with only me
> contributing, there was nobody who really had it on their TODO list to
> review and approve my submissions, so merge times when I was working on
> CORS tests were on the order of 6-8 weeks, and only after I jumped up and
> down and waved a big flag.  That's just not workable to have multiple
> people contributing and be so out of sync.

The review time is indeed a problem. But the outstanding reviews is much
more visible now than before. And we are reviewing more than before.
It's still a problem though. More people should review, especially
people who know the specs.

For events such as TTWF it is quite crucial to have people reviewing
tests just as they come in.  It can be the present experts doing it in
GitHub at the place, or people contributing remotely.  I also think it
would be very helpful if some of the best people reviewed others' tests
at the event.

We had an automatic pull request viewing system before, that was synced
to w3c-test.org, -- that seems to currently be down (due to changes?).
Having  pr-<number>.w3c-test.org  would be quite cool. I'd like to see
something like that turn up again. I remember seeing many reviews about
syncing and server setup, so I hope that's what those reviews were for.

If a group want to work in the same repo, it can be done by working on
the same branch.  Another thing is of course that Git being a
distributed system, - you could push the commits anywhere, or do
something more simple like pulling all the people's branches into a
third party server.

But all of these things are not really tied to the wpt repo, it's more
about server setup.  I'm unsure about what the last best practices were,
but Rebecca Hauck ought to know. :)

A good place to see outstanding pull requests is GitHub:

Or the third party review system Critic (it's nicer to use for advanced
reviewing, but not at all required):

  Odin Hørthe Omdal
Received on Wednesday, 4 June 2014 21:39:44 UTC

This archive was generated by hypermail 2.4.0 : Friday, 17 January 2020 18:54:39 UTC