Re: Review of new CORS tests

So, what's the standard on these issues?  One of the issues is "trailing
whitespace".  Do I really need to "fix" that?  How do I do that?  Abandon
the commit and create a new one?  Can I "edit" it somehow?  Sorry, git newb
here.


On Thu, Oct 3, 2013 at 3:10 PM, Odin Hørthe Omdal <odinho@opera.com> wrote:

> On Thu, Oct 3, 2013, at 23:16, Hill, Brad wrote:
> > Folks with review privileges in WebPlatformTests,  I've checked in
> > updates to the CORS test suite about two weeks ago to handle new status
> > codes.
> >
> > They still await a review before I can commit them:
> >
> > https://critic.hoppipolla.co.uk/r/323
> >
> > If one or more of you could please take a minute to look over the very
> > small set of changes here and submit a review, it will help us advance
> > CORS to PR.
>
> There's open issues on those. :)
>
> And jgraham has rewritten the CORS suite to use the new fancy Python
> based runner. He asked me to fix some problems, and I took a good look
> at it then. It's a very nice way to work! No setup anymore, just "python
> serve.py" and going to the file, and the CORS tests just work. Awesome!
>
> Anyway, I can try to fix up the commits so that they'll be on top of the
> newer master but with a nice, rebased history.
>
> --
>   Odin Hørthe Omdal
>   odinho@opera.com
>
>

Received on Thursday, 3 October 2013 22:13:56 UTC