Re: Tests for new shadow DOM API

Yeah, many of them are still relevant, and I'm working on removing/fixing
obsolete tests (but slowly :).

The most relevant change needed right now is renaming all
"createShadowRoot" to "attachShadow",
which is mechanical, and otherwise all shadow DOM tests are irrelevant ;)

These tests were written a long time ago, so there is definitely lack of
tests for the spec that is
added afterwards.  Some can be modified to adapt the new spec, but we
seriously need tests
for newly-added/modified spec in v1 (notably, <slot> etc.).

So feel free to add new tests, but for existing ones, please leave as they
are, and I'll triage them.
If you are certain that any test is obsolete or irrelevant, please make a
pull request and ping me.




On Fri, Sep 4, 2015 at 5:21 AM, Ryosuke Niwa <rniwa@apple.com> wrote:

> I think many of them are still relevant.  The key problem I have at the
> moment is that I can't tell which ones are relevant and which ones aren't.
> So I wanted to create a new directory and migrate or delete the existing
> tests over time.
>
> On Sep 3, 2015, at 1:19 PM, Travis Leithead <travis.leithead@microsoft.com>
> wrote:
>
> Why not deprecate/remove the existing tests in the current folder
> structure? Presumably we can replace them with new tests that are aligned
> with the recent spec changes?
>
>
>
> If the existing tests really aren’t relevant anymore, I don’t see a reason
> to keep them around.
>
>
>
> *From:* rniwa@apple.com [mailto:rniwa@apple.com <rniwa@apple.com>]
> *Sent:* Thursday, September 3, 2015 1:07 PM
> *To:* public-webapps <public-webapps@w3.org>
> *Subject:* Tests for new shadow DOM API
>
>
>
> Hi all,
>
>
>
> Where should we put tests for new shadow DOM API?  It looks like the tests
> in
> https://github.com/w3c/web-platform-tests/tree/master/shadow-dom/shadow-trees
> <https://urldefense.proofpoint.com/v2/url?u=https-3A__github.com_w3c_web-2Dplatform-2Dtests_tree_master_shadow-2Ddom_shadow-2Dtrees&d=BQMFAg&c=eEvniauFctOgLOKGJOplqw&r=051zrPFUkWGMfGlKdhy9Uw&m=Cn7_iMfgroDlcTadYA5os_RQ7UZZ7tso1e6VXfeC02Q&s=HnBW0AUQSWnlNWyfH6iPEffFNf9pWpcDLVSRRhUEvl0&e=> are
> mostly obsolete and I'm not certain how many of them could be adopted for
> the new API.
>
>
>
> Would it make sense to rename this old one to "deprecated-shadow-don" and
> then create a new top-level directory "shadow-dom"?  We can then migrate or
> write new tests there.
>
>
>
> - R. Niwa
>
>
>
>
>


-- 
Takayoshi Kochi