Re: Overlap between StreamReader and FileReader

On Thu, Aug 8, 2013 at 10:42 PM, Domenic Denicola <
domenic@domenicdenicola.com> wrote:

> Great! Can you explain why this needs to return an
> AbortableProgressPromise, instead of simply a Promise? All existing stream
> APIs (as prototyped in Node.js and in other environments,


Sorry, which one? stream.Readable's readable event and read method?


> such as in js-git's multi-platform implementation) do not signal progress
> or allow aborting at the "during a chunk" level, but instead count on you
> recording progress by yourself depending on what you've seen come in so
> far, and aborting on your own between chunks. This allows better pipelining
> and backpressure down to the network and file descriptor layer, from what I
> understand.
>

I agree flow control is an issue not addressed well yet and needs to be
fixed.

Received on Thursday, 8 August 2013 14:29:30 UTC