Re: Feedback on Quota Management API

On Tue, May 22, 2012 at 2:46 AM, Eric Uhrhane <ericu@chromium.org> wrote:

> On Thu, May 17, 2012 at 2:02 AM, Kinuko Yasuda <kinuko@chromium.org>
> wrote:
> > Thanks for the feedback!
> >
> > For context for others, I assume they are comments for the draft pushed
> at:
> > https://dvcs.w3.org/hg/quota/Overview.html
> >
> > On Tue, May 15, 2012 at 8:17 PM, Anne van Kesteren <annevk@annevk.nl>
> wrote:
> >>
> >> 1) Put storageInfo on window.navigator, not window directly.
> >
> >
> > That sounds reasonable to me given that what window.navigator is
> supposed to
> > represent.
> > I'll change them if no one objects.
> >>
> >> 2) Use the IDL callback syntax. The current IDL is outdated.
> >
> > Thanks, I will fix them.
>

I've updated the draft to use the callback IDL syntax.


>  >>
> >> 3) Use a string enum rather than a constant.
> >
> >
> > They were introduced after the FileSystem API's [1] storage type, which
> also
> > uses a constant.
> > I have no strong opinion on this one and it seems like using string enum
> is
> > more reasonable, but maybe we should change them together if we do so?
> > (Eric, was there a reason we use constants rather than string / string
> enum
> > in FileSystem API?)
>
> I just wrote it that way because I'm a C++ coder.  We can migrate the
> filesystem over to string constants.  If Chrome's TEMPORARY and
> PERSISTENT get redefined to "temporary" and "persistent" from their
> current integer values, folks who are using them won't even notice the
> difference.


Sounds good.  I'll be updating the Quota API draft then, and will be
checking how we can make the change in Chrome.


>  > [1] File API: Directories and System
> http://www.w3.org/TR/file-system-api/
> >
> >> --
> >> Anne — Opera Software
> >> http://annevankesteren.nl/
> >> http://www.opera.com/
> >>
> >
>