W3C home > Mailing lists > Public > public-webapps-testsuite@w3.org > May 2013

Re: [XHR] Review of Microsoft's XHR tests

From: James Graham <jgraham@opera.com>
Date: Wed, 15 May 2013 14:29:52 +0200
Message-ID: <51937FC0.7050702@opera.com>
To: public-webapps-testsuite@w3.org
On 05/14/2013 06:35 PM, Hallvord Reiar Michaelsen Steen wrote:
>
> Hi, I've just looked through Microsoft's submissions in
> http://w3c-test.org/web-platform-tests/master/XMLHttpRequest/tests/submissions/Microsoft/
>
>
Though the scope is limited the tests are excellent and complement the 
tests Opera submitted quite nicely. My first question: can I just move 
those out of the /tests/submissions/Microsoft/ directory into the main 
/XMLHttpRequest directory?
>

We already have a PR open for that move [1] and a code review with an 
issue [2].

If you have reviewed the tests, I suggest you mark that on the code 
review, along with the issues that you found. Then I suggest that you 
push fixes for the issues you found and let someone else (perhaps, 
though not necessarily, someone from Microsoft) review your changes. 
Then we can land the PR and get correct tests in the right position.

[1] https://github.com/w3c/web-platform-tests/pull/50
[2] https://critic.hoppipolla.co.uk/r/27
Received on Wednesday, 15 May 2013 12:30:27 UTC

This archive was generated by hypermail 2.4.0 : Friday, 17 January 2020 18:52:58 UTC