- From: Ms2ger <ms2ger@gmail.com>
- Date: Wed, 09 May 2012 19:29:52 +0200
- To: Odin Hørthe Omdal <odinho@opera.com>
- CC: "public-webapps-testsuite@w3.org" <public-webapps-testsuite@w3.org>, jhlee@infraware.co.kr
Hi Odin, On 05/09/2012 04:02 PM, Odin Hørthe Omdal wrote: > Hey, > > we looked at the WebStorage tests at the webapps-meeting in Mountain > View, and it no-one was passing this particular test. WebKit actually do > now, but I anyway looked at what the test is doing. It should'nt time > out, but rather fail when it throws an exception (like Opera and Firefox > do, still haven't gotten Win8 to work in Virtualbox for testing IE10). > > So I made a patch to the test, and comitted that file to an Opera folder: > > http://w3c-test.org/webapps/WebStorage/tests/approved/event_local_constructor.html > > http://w3c-test.org/webapps/WebStorage/tests/submissions/Opera/event_local_constructor.html > > > The test is much shorter, should be a bit easier to read (YMMV ;-) ), > but most importantly, since it has all the logic inside the real test, > every exception thrown will fail the test. So it tests everything the > old one did, but with more. > > > So I'd like a review of it, if it's accepted I might help with writing > the other tests the same way. > > I'll inline the files for easy reviewing. > > … > > WDYT? (yes, I know we should make bugzilla bugs for this, but I'd rather > just take it up here first for discussion etc.) > I'm afraid I beat you to it; I merged the event_local_constructor.html with event_session_constructor.html, which tested the same thing, and expanded the test. See http://w3c-test.org/webapps/WebStorage/tests/submissions/Infraware/event_constructor.html Comments, of course, welcome. HTH Ms2ger
Received on Wednesday, 9 May 2012 17:30:31 UTC