- From: ArnaudBienner <notifications@github.com>
- Date: Thu, 29 Oct 2026 03:47:50 -0700
- To: w3c/IndexedDB <IndexedDB@noreply.github.com>
- Cc: Subscribed <subscribed@noreply.github.com>
Received on Thursday, 29 October 2026 10:47:54 UTC
@ArnaudBienner commented on this pull request.
> + 1. Let |buffer| be |input|'s [=BufferSource/underlying buffer=].
+
+ 1. If [$IsSharedArrayBuffer$](|buffer|) is true, then return "invalid type".
We could have the following instead:
```suggestion
1. If [$IsSharedArrayBuffer$](|input|'s [=BufferSource/underlying buffer=]) is true, then return "invalid type".
```
It's more concise, avoid the need to declare a `buffer` variable not used afterwards, but I thought it might not be as clear as splitting it over two lines.
--
Reply to this email directly or view it on GitHub:
https://github.com/w3c/IndexedDB/pull/508#pullrequestreview-5268647932
You are receiving this because you are subscribed to this thread.
Message ID: <w3c/IndexedDB/pull/508/review/5268647932@github.com>
Received on Thursday, 29 October 2026 10:47:54 UTC