Re: [w3c/screen-orientation] Add hidden document monitoring in parallel orientation lock steps (PR #272)

@martinthomson commented on this pull request.



> @@ -703,6 +703,11 @@ <h2>
             not `null`, [=reject and nullify the current lock promise=] of
             |document| with an {{"AbortError"}} and abort these steps.
             </li>
+            <li>If |document|'s [=Document/visibility state=] becomes "hidden", and

Should this check for the state being hidden earlier, so that this can be rejected more directly.  This only traps on *becoming* hidden.

-- 
Reply to this email directly or view it on GitHub:
https://github.com/w3c/screen-orientation/pull/272#pullrequestreview-5664379149
You are receiving this because you are subscribed to this thread.

Message ID: <w3c/screen-orientation/pull/272/review/5664379149@github.com>