Re: [whatwg/webidl] Use SafePromiseResolve to replace the promise resolution steps (PR #1645)

mgaudet left a comment (whatwg/webidl#1645)

Regarding:

> - Consider clarifying the scope in the PR description. It says async iteration is left alone, but the async sequence algorithms get the next value and close an async iterator use "a promise resolved with", so they change too. Only next() and return() on asynchronous iterator prototype objects (1, 2) keep calling [[Resolve]]. Also, the change to converting to a promise type affects callback return values (e.g., Streams' pull()), not just arguments.
> - Consider adding a note to those next() and return() steps saying they intentionally keep calling [[Resolve]] to match AsyncGeneratorCompleteStep, so it doesn't read as an oversight.

Yes: I actually have the two line change to change async iteration. I haven't put it up yet however mostly because I haven't entirely internalized how it all is going to come together (and async iteration is relatively rare AFAICT, with only two async_iterables in the firefox webidl) so I was thinking that could happen later if I could untangle the two resolves. 

-- 
Reply to this email directly or view it on GitHub:
https://github.com/whatwg/webidl/pull/1645#issuecomment-6428385790
You are receiving this because you are subscribed to this thread.

Message ID: <whatwg/webidl/pull/1645/c6428385790@github.com>