Re: [w3c/manifest] Add dark mode icons to `color_scheme_dark`, including for shortcut items (PR #1205)

@Copilot commented on this pull request.

<!-- ccr-overview-v2 -->

### 🟡 Changes recommended

Dark-mode app icon updates are not classified as security-sensitive.

<details open>
<summary><strong>1 open finding</strong></summary>

- <picture><source media="(prefers-color-scheme: dark)" srcset="https://github.githubassets.com/static/images/icons/copilot-code-review/high-v2-dark.svg"><source media="(prefers-color-scheme: light)" srcset="https://github.githubassets.com/static/images/icons/copilot-code-review/high-v2-light.svg"><img src="https://github.githubassets.com/static/images/icons/copilot-code-review/high-v2-light.png" alt="High severity" width="62" height="18" align="texttop"></picture> [Dark-mode icon updates bypass security-sensitive permission checks](#discussion_r4228433806) · New
</details>

🧠 **Review effort:** Balanced

> +          <li>[=manifest/icons=]
+          </li>

Adding app icons to `color_scheme_dark` creates a new path for replacing an installed app's icon, but the update rules still classify only `manifest/icons` and `icons_localized` as security-sensitive and explicitly treat every other manifest member as non-security-sensitive (`index.html:1940-1958`). A changed dark-mode icon would therefore be applied immediately without the permission required for other app-icon changes. The security-sensitive update list needs to include the icon representations nested under `color_scheme_dark`.

-- 
Reply to this email directly or view it on GitHub:
https://github.com/w3c/manifest/pull/1205#pullrequestreview-5467984581
You are receiving this because you are subscribed to this thread.

Message ID: <w3c/manifest/pull/1205/review/5467984581@github.com>