Re: [w3c/manifest] chore: merges the explainer into the readme.md (PR #1246)

@Copilot commented on this pull request.

<!-- ccr-overview-v2 -->

### 🔵 Needs a closer look

Several explanations conflict with the specification, and the shortcuts example is invalid JSON.

**0 open findings**

<details>
<summary><strong>3 resolved since last review</strong></summary>

- <picture><source media="(prefers-color-scheme: dark)" srcset="https://github.githubassets.com/static/images/icons/copilot-code-review/low-v2-dark.svg"><source media="(prefers-color-scheme: light)" srcset="https://github.githubassets.com/static/images/icons/copilot-code-review/low-v2-light.svg"><img src="https://github.githubassets.com/static/images/icons/copilot-code-review/low-v2-light.png" alt="Low severity" width="62" height="18" align="texttop"></picture> [These lines duplicate the repository introduction already present at the top of the README. Remove…](#discussion_r3826441602)
- <picture><source media="(prefers-color-scheme: dark)" srcset="https://github.githubassets.com/static/images/icons/copilot-code-review/low-v2-dark.svg"><source media="(prefers-color-scheme: light)" srcset="https://github.githubassets.com/static/images/icons/copilot-code-review/low-v2-light.svg"><img src="https://github.githubassets.com/static/images/icons/copilot-code-review/low-v2-light.png" alt="Low severity" width="62" height="18" align="texttop"></picture> [This section says the specification defines `appinstalled`, but that event was removed from this…](#discussion_r3826441592)
- <picture><source media="(prefers-color-scheme: dark)" srcset="https://github.githubassets.com/static/images/icons/copilot-code-review/low-v2-dark.svg"><source media="(prefers-color-scheme: light)" srcset="https://github.githubassets.com/static/images/icons/copilot-code-review/low-v2-light.svg"><img src="https://github.githubassets.com/static/images/icons/copilot-code-review/low-v2-light.png" alt="Low severity" width="62" height="18" align="texttop"></picture> [This trailing comma makes the manifest example invalid JSON, so copying it into a manifest will…](#discussion_r3826441583)
</details>

<details>
<summary><strong>Previously missed (5)</strong></summary>

In code that hasn't changed since last review

<details>
<summary><picture><source media="(prefers-color-scheme: dark)" srcset="https://github.githubassets.com/static/images/icons/copilot-code-review/medium-v2-dark.svg"><source media="(prefers-color-scheme: light)" srcset="https://github.githubassets.com/static/images/icons/copilot-code-review/medium-v2-light.svg"><img src="https://github.githubassets.com/static/images/icons/copilot-code-review/medium-v2-light.png" alt="Medium severity" width="62" height="18" align="texttop"></picture> Narrow lang description to localizable manifest members</summary>

`README.md:192`

`lang` does not declare the language of every textual manifest value; the specification applies it only to localizable members. Describing it as the language of all “manifest text values” can mislead authors about members such as URLs and enums. Please use the specification's narrower scope (see `index.html:1003-1007`).
</details>

<details>
<summary><picture><source media="(prefers-color-scheme: dark)" srcset="https://github.githubassets.com/static/images/icons/copilot-code-review/medium-v2-dark.svg"><source media="(prefers-color-scheme: light)" srcset="https://github.githubassets.com/static/images/icons/copilot-code-review/medium-v2-light.svg"><img src="https://github.githubassets.com/static/images/icons/copilot-code-review/medium-v2-light.png" alt="Medium severity" width="62" height="18" align="texttop"></picture> Identify description as part of the Application Information supplement</summary>

`README.md:198`

This presents `description` as a member of the core Web App Manifest specification, but the repository's specification says the application-level member was moved to the Application Information supplement (`index.html:4349-4364`). Please identify and link that supplement so readers do not confuse this with the shortcut item's separate `description` member.
</details>

<details>
<summary><picture><source media="(prefers-color-scheme: dark)" srcset="https://github.githubassets.com/static/images/icons/copilot-code-review/medium-v2-dark.svg"><source media="(prefers-color-scheme: light)" srcset="https://github.githubassets.com/static/images/icons/copilot-code-review/medium-v2-light.svg"><img src="https://github.githubassets.com/static/images/icons/copilot-code-review/medium-v2-light.png" alt="Medium severity" width="62" height="18" align="texttop"></picture> Broaden background_color description beyond home-screen splash screens</summary>

`README.md:205`

This description is too narrow: `background_color` can be used whenever the manifest is available before the application's files or stylesheet, not only for a splash screen launched from the home screen. The normative description in `index.html:2027-2039` explicitly covers resources loaded from either network or disk.
</details>

<details>
<summary><picture><source media="(prefers-color-scheme: dark)" srcset="https://github.githubassets.com/static/images/icons/copilot-code-review/medium-v2-dark.svg"><source media="(prefers-color-scheme: light)" srcset="https://github.githubassets.com/static/images/icons/copilot-code-review/medium-v2-light.svg"><img src="https://github.githubassets.com/static/images/icons/copilot-code-review/medium-v2-light.png" alt="Medium severity" width="62" height="18" align="texttop"></picture> Wrap shortcuts example in a valid JSON object</summary>

`README.md:211`

The fenced block is labeled JSON, but it starts with a property rather than an object, so readers cannot copy or parse the example as JSON. Wrap the `shortcuts` property and array in `{ ... }`, as the other manifest examples do.
</details>

<details>
<summary><picture><source media="(prefers-color-scheme: dark)" srcset="https://github.githubassets.com/static/images/icons/copilot-code-review/medium-v2-dark.svg"><source media="(prefers-color-scheme: light)" srcset="https://github.githubassets.com/static/images/icons/copilot-code-review/medium-v2-light.svg"><img src="https://github.githubassets.com/static/images/icons/copilot-code-review/medium-v2-light.png" alt="Medium severity" width="62" height="18" align="texttop"></picture> Replace stale implementation-status claims with maintained compatibility data</summary>

`README.md:279`

This implementation-status paragraph is now stale and conflates support for manifest members with PWA installation support; a static vendor list will keep aging and currently omits major implementations. Replace it with a maintained compatibility reference rather than asserting that Firefox support is not shipping.
</details>
</details>

🧠 **Review effort:** Balanced

---

Give feedback about Copilot approvals in [this survey](https://survey.alchemer.com/s3/9011660/CCR-Public-Preview-Autoapprove-feedback-survey) to enter a drawing for a $150 gift card.



-- 
Reply to this email directly or view it on GitHub:
https://github.com/w3c/manifest/pull/1246#pullrequestreview-5456016771
You are receiving this because you are subscribed to this thread.

Message ID: <w3c/manifest/pull/1246/review/5456016771@github.com>